Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Patch set 1:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #1:
Oh I didn't know it's a valid use case to invoke initialisation with NULL prog params :\ But now I know, and this should be covered by unit test.
I created one in CB:67642, currently fails at head and passes on the top of this revert. Test can be merged after the revert, and then whatever is another version of removing global programmer_param, test will run over it.
To view, visit change 67621. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b689ad4bdd0c9c3b11f30becafc878c78630f0b
Gerrit-Change-Number: 67621
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Tue, 13 Sep 2022 23:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment