Attention is currently required from: Nico Huber, Sergii Dmytruk.

View Change

2 comments:

• Patchset:

  • Patch Set #39:

    Wouldn't that just duplicate test name, code and comments in tests? Maybe provide an example of a de […]

    Something like
    `Enable wp and verify that it can not be unset` for `switch_wp_mode_dummyflasher_test_success`

    I think that may be helpful when a test fails and you start looking into the code.

• File tests/chip_wp.c:

  • Patch Set #39, Line 63: static const struct flashchip chip_W25Q128_V = {

    It's copied in `chip.c`, so I did the same. […]

    Ack

To view, visit change 59075. To unsubscribe, or for help writing mail filters, visit settings.