Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
2 comments:
Patchset:
Part of me wants to split this patch into smaller ones. […]
Thanks Anastasia, good point. I have been reworking as a series of patches, my feeble brain cannot handle all the changes in one go either! I will try to get it up today. Easier to squash after review than to split in my opinion.
File cli_classic.c:
Patch Set #4, Line 146: *start != tmp
What is this condition checking? I am confused because the previous line made the assignment and thi […]
Yes this is checking that the user provided value can fit in a chipsize_t. I think I will remove it.
The point here was that the size of start was being hidden inside chipsize_t, so we really ought to parse a large type and then double check that it fits. But actually we arent so much hiding the size which is publicly uint32_t, as just putting all the sizes into a typedef for some documentation.
To view, visit change 67004. To unsubscribe, or for help writing mail filters, visit settings.