Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.

View Change

2 comments:

• File tests/chip.c:

  • Patch Set #1, Line 42: printf("Unlock chip called\n");

    Currently unlock is optional, which is […]

    If you're emulating a chip, I'd also mock and verify locking to increase test coverage

  • Patch Set #1, Line 57: char *param_dup = strdup("");

    This only works for the case when param is empty string. […]

    Hmmm, I guess the `memmove` inside that function changes the haystack. If so... Eww!

To view, visit change 56501. To unsubscribe, or for help writing mail filters, visit settings.