Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk.

View Change

2 comments:

• File layout.c:

  • Patch Set #8, Line 413: struct romentry *const entry = malloc(sizeof(*entry));

    Given that you memset() the allocated space afterwards, use calloc() instead?

  • Patch Set #8, Line 418: entry->next = layout->head;

    Does this mean entries are in a loop? Given `layout->head = entry` below?

    No loops here, this is just a linked list. New elements are added as new heads of the list, the old head becomes the next element of the newly-inserted element.

To view, visit change 33521. To unsubscribe, or for help writing mail filters, visit settings.