Edward O'Callaghan submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
cli_classic.c: Drop spurious cast

This cast should not be required.

Change-Id: Ia3a658dd6f4986eb6da84a11bce66f53e1571469
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/72966
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
---
M cli_classic.c
1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/cli_classic.c b/cli_classic.c
index c72836f..da68919 100644
--- a/cli_classic.c
+++ b/cli_classic.c
@@ -662,8 +662,7 @@
* chip when a flash device gets opened with fd 1 or 2.
*/
if (check_file(stdout) && check_file(stderr)) {
- flashrom_set_log_callback(
- (flashrom_log_callback *)&flashrom_print_cb);
+ flashrom_set_log_callback(&flashrom_print_cb);
}

print_version();

To view, visit change 72966. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia3a658dd6f4986eb6da84a11bce66f53e1571469
Gerrit-Change-Number: 72966
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged