Attention is currently required from: Alexander Goncharov, Peter Marheine.
View Change
1 comment:
Patchset:
Patch Set #1:
Many users just want to compile things and don't care about running the tests, so I think it's reaso […]
That's a good idea, and I forgot about TLDR in README. I added there too.
About marking optional: I thought about it for a bit. There is currently a `meson install` command in both docs, which is also optional and not everyone needs it.
Peter, do you think we should mark both as optional?
I have the thought of, maybe people would understand that if they just need to compile than they just run compile, and if they need tests they run tests?
To view, visit change 78689. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I67d5f4decdac15e6a72f4372135dab7d44396594
Gerrit-Change-Number: 78689
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Jes Klinke <jbk@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Mon, 30 Oct 2023 09:35:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment