You can assume for now that not replying to a specific bit of feedback means "will fix"...

4 comments:

File developerbox_spi.c:
- Patch Set #3, Line 8: version 2 of the License
  is it intentional to restrict the license to v2?
  This would have been copied from the existing code. I just got "unlucky". Across the code base it looks like there is currently an approximate 60/40 split in favour or "or later". I'm happy to change this.
- Patch Set #3, Line 28: DSW4-1
  DSW4-1 is the most significant bit?
  The presentation here is more geometric than numeric! DW4-1 is left most switch in the DIP panel (with "up" defined by the text on the silkscreen). I think this phrasing is unambiguous for someone who can see the board.
- Patch Set #3, Line 181: strlen(serialno)
  strncmp() with `n == strlen()` of one of its arguments looks very odd. […]
  I'll add a comment. The intent is to permit a partial prefix (developers influences how git handles partial SHA-1 hashes grow to expect this).
- Patch Set #3, Line 207: commencing
  heh, should have read this first...
  :-)
  I'll add a comment anyway.

To view, visit change 26948. To unsubscribe, or for help writing mail filters, visit settings.