Patch Set 2: Code-Review-1

(1 comment)

We have had a discussion with Hrvoje that the delay calibration should be only performed for programmers which rely on (mainly bitbanging programmers I think). He is using linux_spi programmer where I doubt that it is necessary. So it might be more useful to fix this fixme:
https://github.com/flashrom/flashrom/blob/master/cli_classic.c#L456
So rather than adding an argument it might makes more sense to run the delay calibration only when it is really necessary.

View Change

To view, visit change 39841. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea2a7f62300663bc0a32ed4abced57c8c55c90c8
Gerrit-Change-Number: 39841
Gerrit-PatchSet: 2
Gerrit-Owner: Hrvoje Čavrak <github@hrvoje.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 26 Mar 2020 08:20:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment