Attention is currently required from: Anastasia Klimchuk.

View Change

10 comments:

• Commit Message:

  • Patch Set #2, Line 9: I was working on an

    During the development of

    Done

  • Patch Set #2, Line 9: pet

    maybe remove "pet" :)

    Done

  • Patch Set #2, Line 10: when i implemented

    implementation of

    Done

  • Patch Set #2, Line 11: i

    uppercase

    Done

  • Patch Set #2, Line 14: I added

    This patch adds

    Done

  • Patch Set #2, Line 18: After that

    TESTED=

    Done

• Patchset:

  • Patch Set #2:

    Thank you for you patch! I added some comments. […]

    Thank you for your detailed review!

    Not sure what happened with the email - most likely i should have set all the names in Gerrit before sending the patch

• File serial.c:

  • Patch Set #2, Line 380:

    int ret = tcflush(sp_fd, TCIFLUSH);
    	if (ret == 0)
    		return;
    

    We typically use more compact variation. […]

    Done

  • Patch Set #2, Line 392: ret > 0

    A question about return codes: `serialport_read_nonblock` can return positive or negative error code […]

    Done

  • Patch Set #2, Line 401: return;

    I am thinking, maybe change slightly with less returns. […]

    yeah, i'm a bit uncomfortable with this too, but i actually have no idea what to do if something else occurs especially since there is no return value to indicate that

    i considered leaving the original FIXME: error handling comment here too

    the only thing i'm pretty sure about - any error other than ENOTTY means sp_fd is in unrecoverable state and any following read/write operation will fail too

    i have made the changes you suggested and added some new comments

To view, visit change 79112. To unsubscribe, or for help writing mail filters, visit settings.