With regards to chromiumos compatibility, I guess the important thing for now is to make sure that the syntax handling stays in the CLI code so that they can continue using their CLI (cli_mfg.c in their tree).

Personally I think the CrOS syntax is simple enough and is very useful, but I don't mind if we do something more strict for upstream to start with.

View Change

To view, visit change 23022. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 23022
Gerrit-PatchSet: 12
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 22 Jan 2018 01:17:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No