View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: dropping ich_generation global
Is this desired to make testing easier? If so, I'd update the commit message.
I suppose it could however we are a bit far from that goal with ich at the moment I think. The later on patches are more heading in that direction however this one in particular is more just a cleean up to make the function a little less silly.
To view, visit change 43498. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5293e7ae6f20a2299577172655c2926861091f5a
Gerrit-Change-Number: 43498
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 16 Jul 2020 12:02:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment