I'm missing a check for spurious arguments. I have no idea how to
implement it (straightforward) together with the non-positional
file
names. Currently, if you have a typo in your command line (e.g.
forget
a dash before an option), things may just be ignored...
So why make it non-positional?
Is there a way to change the argument amount on -r/-w/-v since without this change, using -i region:file one always needs a filename next to -r/-w/-v which sort of defeats the purpose of the previous patch.
View Change
To view, visit change 23022. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 23022
Gerrit-PatchSet: 6
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 19 Jan 2018 11:10:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No