Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Paul Menzel, Stefan Reinauer, David Hendricks, Daniel Campello, Arthur Heymans, Carl-Daniel Hailfinger.

Patch set 25:Code-Review +1

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #25, Line 140:

    static char *get_optional_filename(char *argv[])
    {
    	char *filename = NULL;
    
    	if (optarg == NULL && argv[optind] != NULL && argv[optind][0] != '-')
    		filename = strdup(argv[optind++]);
    	else if (optarg != NULL)
    		filename = strdup(optarg);
    
    	return filename;
    }
    

    Not a overtly strong feeling here however should this part of the story perhaps be a separate patch? Even if it is small, it is however a specific singular purpose change to the cli that perhaps stands on its own merit.

  • Patch Set #25, Line 203: 'i'}

    I guess this would be a breaking change, I would defer to Nico and Angels judgement here.

    However my suggestion is that we use capital `I` for "include" as to avoid changing lower case `i` from meaning "image".

To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.