Attention is currently required from: Aarya, Carly Zlabek, Vincent Fazio.
2 comments:
Patchset:
Carly, thank you so much for the patch! You are right, there is a redundant verification. Which is partially my mistake, because I removed redundant erase earlier (in CB:77747 ) and forgot to remove the correspondent redundant verification.
Your idea is very good, but I think we need to remove a different verification instead, the one which corresponds to erase invocation removed in CB:77747. Which is in this Patchset 1 lines #353-359.
Just to be clear: I think to remove lines #353-359 *instead*, so return back lines #388-394.
It should have the same effect: one less verification, but logically removing the "orphaned" verification, and keep the one which follows the write.
Would it be possible for you to re-run the test 3. with this?
Thank you!
Testing Summary: […]
This is great, I really appreciate detailed testing info.
To view, visit change 79354. To unsubscribe, or for help writing mail filters, visit settings.