Attention is currently required from: David Hendricks, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• Patchset:

  • Patch Set #8:

    What I mentioned to Thomas offline once: We could also add
    an offset parameter. e.g.

        uint32_t read_le32(const void *src, size_t offset);

    This would have the benefit that the reader would always see
    that the offset is in bytes. For instance, consider these two
    calls:

        uint32_t *buf, val;
        ...
        val = read_le32(buf + 3);
        val = read_le32(buf, 12);

    They are supposed to do the same. But in the first case we
    need to have pointer-arithmetic in mind to see it. The second
    case would always be the same, no matter the type of `buf`.

To view, visit change 31016. To unsubscribe, or for help writing mail filters, visit settings.