Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
File tests/meson.build:
Patch Set #10, Line 32:
p_data += {
'testsrc' : p_data.get('testsrc', []),
}
srcs += p_data.get('testsrc')
> I came up with one question, wanted to clarify. […]
I just created CB:68359, which makes use of weak functions and removes the ifdefs. This also removes the need to compile in all test files. Though, not sure if that is an actual advantage. What might be an advantage that the linker does the work for us instead the pre-processor ifs.
To view, visit change 68162. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I307faaf8a9f7ae3c54bd96e7d871a3abb8aadea3
Gerrit-Change-Number: 68162
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 12 Oct 2022 23:11:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment