Attention is currently required from: Edward O'Callaghan, Aarya, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #2:
Currently we are checking for wp from region->write_prot but that only works for BUS_PROG. […]
It's worth noting that `region->write_prot` is used to indicate a different type of protection to normal chip-based WP.
`get_region()` allows opaque programmers to indicate that part of the flash is protected by the programmer/chipset. It is currently only used by the ICH (intel chipset) driver because the intel chipset blocks access to some flash regions.
To view, visit change 74872. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie13e43b18b20dbb956b569e554953a19eb32ea22
Gerrit-Change-Number: 74872
Gerrit-PatchSet: 3
Gerrit-Owner: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 03 May 2023 01:27:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Aarya <aarya.chaumal@gmail.com>
Gerrit-MessageType: comment