Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.

View Change

1 comment:

• File include/programmer.h:

  • Patch Set #6, Line 405:

    int (*read_register)(const struct flashctx *flash, enum flash_reg reg, uint8_t *value);
    	int (*write_register)(const struct flashctx *flash, enum flash_reg reg, uint8_t value);
    

    If these are meant to stay WP only, they should have "wp_" prefix.

    That is a fair point however this was intentional since r/w register is not necessarily specific to only writeprotect.c it is just that the use-case happens to be that right now.

    The hooks are intended to be general purpose, another use-case I have potentially in mind is for libflashrom to facilitate dumping register state.

To view, visit change 64375. To unsubscribe, or for help writing mail filters, visit settings.