Attention is currently required from: Nico Huber, Angel Pons, Neill Corlett.
Patch set 2:Code-Review +2
View Change
2 comments:
File mediatek_i2c_spi.c:
Patch Set #1, Line 96: args.data->block
Inclined to leave as-is unless there are strong objections.
Ack. Angel is right, I like avoiding such things but Nico's point is fair style.
Patch Set #1, Line 249: 0x426, 7
My understanding is that this is the usual, expected, line that's supposed to go to WP#. […]
Having seen these kinds of datasheets before I know what you mean Neill lol. I think we may never know the precise meanings here.
To view, visit change 61288. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I24adb14e7b4f7160e1c3ff941774064d5a81e820
Gerrit-Change-Number: 61288
Gerrit-PatchSet: 2
Gerrit-Owner: Neill Corlett <corlett@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Neill Corlett <corlett@google.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 12:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Neill Corlett <corlett@google.com>
Gerrit-MessageType: comment