Attention is currently required from: Edward O'Callaghan, Peter Marheine.
View Change
2 comments:
File layout.c:
Patch Set #1, Line 296: layout->entries[i].included = false;
Should this line also move into flashrom_layout_release() ?
Patch Set #1, Line 279: layout_cleanup_args
This function is not cleaning up the layout anymore, only args. Maybe you can rename to `cleanup_layout_args`? or `args_cleanup` ?
To view, visit change 54147. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515
Gerrit-Change-Number: 54147
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Thu, 13 May 2021 00:18:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment