Angel Pons has uploaded this change for review.

View Change

dummyflasher.c: Don't leak `emu_persistent_image`

Ensure `emu_persistent_image` doesn't end up leaking memory.

Change-Id: I76529973cefcc6a1472681e1f4da8239fcbf07a6
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
---
M dummyflasher.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/54905/1

diff --git a/dummyflasher.c b/dummyflasher.c
index 2f39c98..8955254 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -646,9 +646,8 @@
 			write_buf_to_file(emu_data->flashchip_contents,
 					  emu_data->emu_chip_size,
 					  emu_data->emu_persistent_image);
-			free(emu_data->emu_persistent_image);
-			emu_data->emu_persistent_image = NULL;
 		}
+		free(emu_data->emu_persistent_image);
 		free(emu_data->flashchip_contents);
 	}
 #endif
@@ -1012,6 +1011,7 @@
 			if (read_buf_from_file(data->flashchip_contents, data->emu_chip_size,
 					   data->emu_persistent_image)) {
 				msg_perr("Unable to read %s\n", data->emu_persistent_image);
+				free(data->emu_persistent_image);
 				free(data->flashchip_contents);
 				return 1;
 			}
@@ -1023,6 +1023,7 @@
 
 dummy_init_out:
 	if (register_shutdown(dummy_shutdown, data)) {
+		free(data->emu_persistent_image);
 		free(data->flashchip_contents);
 		free(data);
 		return 1;

To view, visit change 54905. To unsubscribe, or for help writing mail filters, visit settings.