Attention is currently required from: Nico Huber, Edward O'Callaghan.
View Change
1 comment:
Patchset:
Patch Set #1:
https://review.coreboot.org/c/flashrom/+/51676 […]
Mine was CB:51761 which has everyone +2s and it was the end goal to submit after I do all refactorings.
Yeah it has overlap with this one... but I would need to do more function signature changes, not only data, also data size and shutdown function.
I still have lots of global state to remove, and if this one and next one in the chain both are submitted I would need one less line for every refactoring.
To view, visit change 54066. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c753b3db050fb87d4bbe2301a7ead854f28456f
Gerrit-Change-Number: 54066
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Wed, 12 May 2021 05:32:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment