Attention is currently required from: Evan Benn.

View Change

2 comments:

• File tests/io_mock.h:

  • Patch Set #4, Line 37: #include <fcntl.h>

    this one is posix, and posix says: `The <fcntl.h> header shall define the mode_t` […]

    I will try to test

• File tests/tests.c:

  • Patch Set #4, Line 103:

    mode_t mode = 0;
    	if (flags & O_CREAT) {
    		va_list ap;
    		va_start(ap, flags);
    		mode = va_arg(ap, mode_t);
    		va_end(ap);
    	}
    

    It has to be in the varargs function. […]

    open64 and open64_2 are needed for some of the environments, so we can't remove them. Let's keep as is then.

To view, visit change 69263. To unsubscribe, or for help writing mail filters, visit settings.