Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10:
You need to add Signed-off-by tag with you name and email (it's a requirement for flashrom, see guidelines https://www.flashrom.org/Development_Guidelines#Sign-off_Procedure )
And this is why build failed: if you look at console output of jenkins, it tells that sign-off tag is missing.
Other than that, all great, thank you so much!!
To view, visit change 72181. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia548d23d15f0efa92d83577d3106e6231ed7688f
Gerrit-Change-Number: 72181
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sat, 21 Jan 2023 07:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment