Attention is currently required from: Michał Żygowski, Paul Menzel.

Patch set 12:Code-Review +2

View Change

2 comments:

• File chipset_enable.c:

  • Patch Set #3, Line 659: { "eSPI", BUS_LPC | BUS_FWH } };

    Done. […]

    Thanks! that's even better :)

• File flash.h:

  • Patch Set #10, Line 71: BUS_NONSPI = BUS_PARALLEL | BUS_LPC | BUS_FWH,

    Hard to tell. BUS_NONSPI is mostly used on older southbridges/chipsets in chipset_enable. […]

    Heh, I was wondering about that comment too. Maybe it means that once we
    treat all bus types similarly in common code, we won't have to check for
    SPI/NONSPI explicitly anywhere.

To view, visit change 55578. To unsubscribe, or for help writing mail filters, visit settings.