Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.
View Change
2 comments:
Commit Message:
Patch Set #3, Line 17: flow now.
IMO it becomes harder to read. Is there anything in
the queue ahead that follows up on this?
File pcidev.c:
Patch Set #3, Line 37: saved_pacc
This is not what one would expect. Usually the result of assignments
and setters is the assigned value.
To view, visit change 59278. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3bea1b93a7ca81dd42a64eec1e49a10f1fbda850
Gerrit-Change-Number: 59278
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Wed, 15 Dec 2021 11:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment