David Hendricks posted comments on this change.
View Change
Patch set 5:Code-Review +2
(1 comment)
File spi25.c:
Patch Set #5, Line 380: "Please report a bug at flashrom@flashrom.org\n");
Not a bug, I forgot about the block erasers (again)... or we could
How so? If you're referring to chip erase commands, those are handled using spi_simple_write_cmd() which doesn't call this function, so we should be good there at least.
To view, visit change 22421. To unsubscribe, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c
Gerrit-Change-Number: 22421
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 23 Nov 2017 06:23:20 +0000
Gerrit-HasComments: Yes