View Change

1 comment:

• File jlink_spi.c:

  • Patch Set #1, Line 168: .max_data_read = JTAG_MAX_TRANSFER_SIZE,

    The correct interpretation of the comment above is that
    we have to tell here how much payload we can take. Which
    is `JTAG_MAX_TRANSFER_SIZE - 4` or `- 5` if we allow 4B
    addresses. (The interface is just wrong and should change
    in the future. The SPI drivers shouldn't predict the
    protocol overhead. But for now we have to do the calcu-
    lation here.)

    Please add `- 5` to both `.max_data_(read|write)`, and
    set `.features = SPI_MASTER_4BA,` (I don't see a reason
    why it shouldn't work oob).

To view, visit change 28087. To unsubscribe, or for help writing mail filters, visit settings.