Attention is currently required from: Nico Huber.

View Change

2 comments:

• File usbblaster_spi.c:

  • Patch Set #1, Line 55: struct ftdi_context ftdic;

    Having a struct with only one member looks odd, but it makes sense for consistency with other progra […]

    Oh I had the same question in CB:52774 and I explained why I am doing this (in short, mostly so that I can calloc and free data). But I wrote a much longer comment in CB:52774 , you are very welcome to read all that :)

  • Patch Set #1, Line 185: struct ftdi_context ftdic;

    We could allocate `usbblaster_data` early and use `usbblaster_data->ftdic` instead of having a secon […]

    I usually try to allocate data as late as possible to simplify error paths (as soon as you allocate data, you need to take care to free it for all error paths after that). So it was intentional, can I leave it? what do you think?

To view, visit change 54044. To unsubscribe, or for help writing mail filters, visit settings.