Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Patch set 2:Code-Review +2
View Change
1 comment:
File tests/chip.c:
Patch Set #1, Line 29: g_chip_state
Good idea, totally makes sense! I was going to do it quickly, but then I realised I don't know how t […]
Alas, there is no proper abstraction yet. Some of the field of struct
flashrom_flashctx look chip specific (e.g. those about SPI 4BA), so
looks like there is a reason for another data pointer even without
the tests.
To view, visit change 57436. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If59315646f06344664df08b145866d9ce846d751
Gerrit-Change-Number: 57436
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Sun, 12 Sep 2021 12:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment