Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
stlinkv3_spi.c: Improve printed messages

Add missing line ends, and add a note about the first version of the
updater which contains the necessary V3 bridge feature.

Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Signed-off-by: Miklós Márton <martonmiklosqdev@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/43900
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M stlinkv3_spi.c
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c
index ae865be..7e8336e 100644
--- a/stlinkv3_spi.c
+++ b/stlinkv3_spi.c
@@ -253,21 +253,22 @@
enum fw_version_check_result fw_check_result;

if (stlinkv3_check_version(&fw_check_result)) {
- msg_perr("Failed to query FW version");
+ msg_perr("Failed to query FW version\n");
return -1;
}

if (fw_check_result != FW_VERSION_OK) {
- msg_pinfo("Your STLink V3 has too old version of the bridge interface\n"
- "Please update the firmware with the STSW-LINK007 which can be downloaded from here:\n"
- "https://www.st.com/en/development-tools/stsw-link007.html");
+ msg_pinfo("Your STLink V3 has a too old version of the bridge interface\n"
+ "Please update the firmware to version 2.33.25 or newer of the STSW-LINK007\n"
+ "which can be downloaded from here:\n"
+ "https://www.st.com/en/development-tools/stsw-link007.html\n");
return -1;
}

if (stlinkv3_spi_calc_prescaler(reqested_freq_in_kHz,
&prescaler,
&SCK_freq_in_kHz)) {
- msg_perr("Failed to calculate SPI clock prescaler");
+ msg_perr("Failed to calculate SPI clock prescaler\n");
return -1;
}
msg_pinfo("SCK frequency set to %d kHz\n", SCK_freq_in_kHz);

To view, visit change 43900. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70
Gerrit-Change-Number: 43900
Gerrit-PatchSet: 5
Gerrit-Owner: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged