Patch Set 1:

Patch Set 1:

Patch Set 1:

What? No! Don't abandon this change, please!

Please no more unnecessary C89'ism. Just use C99 already.

Did you check the change I linked to earlier? Old GCC versions don't like these kinds of initializers, and it caused problems at some point. And even if that is no longer an issue, the other three loops in this file as well as nearly every other file in flashrom use the C89 style.

I did indeed check. We shouldn't walk backwards though. If your GCC is so old that it doesn't support C99 (~20years) I don't we should support that. The issue above is that newer GCC's since 8-9y ago? defaulted to C99 and so you don't need to be explicit about -std=c99 as it is assumed. However just assuming isn't good either, we should be explicit about using C99 and fix C89'ism across the code base.

View Change

To view, visit change 47874. To unsubscribe, or for help writing mail filters, visit settings.