View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 7: WIP: flashrom: import chip restore handler from cros flashrom

    Worth writing out a detailed commit message now about what this infrastructure is and why its needed for s25f variant chips with BUG/BRANCH/TEST lines.

    Otherwise I think this architecture looks much better now and looks possible to write a unit-test for!

• File flash.h:

  • Patch Set #2, Line 282: int (*func) (struct flashctx *flash, uint8_t status)

    typedef this callback signature somewhere sensible above and use that everywhere as the type.

    `typedef int (*chip_restore_fn_cb_t)(struct flashctx *flash, uint8_t status);`

  • Patch Set #2, Line 360: int (*func) (struct flashctx *flash, uint8_t status),

    `chip_restore_fn_cb_t func,`

• File flashrom.c:

  • Patch Set #2, Line 583: int (*func) (struct flashctx *flash, uint8_t status),

    `chip_restore_fn_cb_t func,`

To view, visit change 47276. To unsubscribe, or for help writing mail filters, visit settings.