Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.

View Change

1 comment:

• File include/libflashrom.h:

  • Patch Set #2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead

    Well, it's not backwards compatible for sure. […]

    There is an important detail here, I will try to explain the full context.

    The old version of API was unusable, the commit message in CB:64663 explains it. The input to the callback, flashctx, was not possible to peek into for external clients.

    In other words, old API was not possible to use for external clients without one more patch. And CB:64663 could be one options of that "one more patch", but after discussion there, I think changing the API is more correct, so I made this patch instead.
    But one way or the other, what is currently in the tree, is not usable by external clients. (It does build of course).

    So keeping the old implementation, and as you said that would require storing two callbacks - I don't want to do this, because that would be just a dead code.

    However, somehow this needs to move on. I understand some formality is needed because we are changing the public API. What would be the minimum required to get this v2 in? Because really, the old version was not possible to use anyway (except of internal clients as cli and tests, but these can be changed easily)

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.