Attention is currently required from: Nico Huber, Martin L Roth, Thomas Heijligen, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Martin Roth.

Patch set 1:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Martin, I apologise, you can ignore previous comment. […]

    btw, this was originally purposed in CB:36434 but never went anyway unfortunately. I originally chose FCH as a name to be consistent with ICH and as that is where the SPI controller is situated physically within the fabric of the FCH. Technically, 'ichspi' is confusing as it contains both ich and pch implementations.

    I did ask AMD at the time what could be a better name and how the driver could be best split up. I just couldn't get a clear answer at the time on what the names should be?

    I suspect what we want is to rename this to amd_spi.c initially but then split this driver and have amd_fch to refer to the common functions? I am going to lean on Martins judgement here since he has best visibility and understanding of this peripheral controller across many generations. In the case of ichspi it should probably have the same treatment/theme.

To view, visit change 74952. To unsubscribe, or for help writing mail filters, visit settings.