Attention is currently required from: Miklós Márton, Peter Marheine.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #3, Line 487: for (int i = 0; opcode[i]; i++) {

    > I would say "chips that don't have erase operation capability, and no erase opcodes"? […]

    Thank you so much for explanations! It's so useful.
    I made a first attempt to add a comment for FEATURE_NO_ERASE in the header include/flash.h. But please tell me if it's a correct comment.

• File flashrom.c:

  • Patch Set #4, Line 485: !(flash->chip->feature_bits & FEATURE_NO_ERASE)

    I don't think you need this check, and for a chip that doesn't need erase but supports a fast erase […]

    Yep, removed the check. I wasn't entirely sure which way to go, so I left it in the previous patchset (but now removed). Checking opcode for null is enough.

To view, visit change 84203. To unsubscribe, or for help writing mail filters, visit settings.