Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.

View Change

1 comment:

• File rayer_spi.c:

  • Patch Set #1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0)

    Hmmm, does it make sense to get I/O perms before parsing programmer params?

    That is a very good question, this maybe subjective patch though so I don't have strong feelings yet about it. However my internal reasoning was the following:

    conceptual rubrics:
    i) check permissions&&resource requirements are meet before doing anything,
    ii) check programmer configuration before init'ing,
    iii) do programmer init.

    the next step based off these rubrics, or flow if you will, would be to move (i)&&(ii) into core logic and only ever enter the programmer entry once (i)&&(ii) has satisfiability.

    Though I admit this patch on its own doesn't tell the above story so we could leave it for now.

To view, visit change 68231. To unsubscribe, or for help writing mail filters, visit settings.