Looks good, just some minor comments. I have only looked at the diff
of different patch sets lately, will try to have a final look over
everything soon.

View Change

5 comments:

• File cli_classic.c:

  • Patch Set #20, Line 95: int main(int argc, char *argv[])

    I just remembered that we have a read_buf_from_file() function in
    flashrom.c.

    Well, you could have kept read_file() and called read_buf_from_file()
    from there. Doesn't matter.

    Would be nice to have a file handling library
    eventually to make this stuff more obvious.

    Agreed.

• File cli_classic.c:

  • Patch Set #22, Line 619: out

    out_shutdown

• File flashrom.8.tmpl:

  • Patch Set #22, Line 219: (e.g. a coreboot rom image) in the argument and use it to create a layout.

    leftover

• File fmap.h:

  • Patch Set #20, Line 70:

    I should have mentioned, that I didn't mark all occurrences ;)

• File fmap.c:

  • Patch Set #22, Line 153:

    	if (!flashctx || !flashctx->chip)
    		return 1;
    

    Redundant, probably leftover?

To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.