Looks good, just some minor comments. I have only looked at the diff
of different patch sets lately, will try to have a final look over
Patch Set #20, Line 95:
int main(int argc, char *argv)
I just remembered that we have a read_buf_from_file() function in
Well, you could have kept read_file() and called read_buf_from_file()
from there. Doesn't matter.
Would be nice to have a file handling library
eventually to make this stuff more obvious.
Patch Set #22, Line 219:
(e.g. a coreboot rom image) in the argument and use it to create a layout.
I should have mentioned, that I didn't mark all occurrences ;)
if (!flashctx || !flashctx->chip)
Redundant, probably leftover?
To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.