View Change

3 comments:

• Commit Message:

  • Patch Set #16, Line 12: the programmer groups individually.

    I don't quite understand. What could lead to break the groups if
    all at once and every programmer individually work?

• File test_build.sh:

  • Patch Set #15, Line 57: # In case of clang analyzer we don't want to run it on

    I wanted to avoid that and I didn't find another way than doing this.

    The standard way to avoid duplication are functions. Not sure if I missed
    anything why that wouldn't work here. Calling site could look like this:
    ```
    single_meson_build all
    if [ ${is_scan_build} -ne 1 ]; then
            return
    fi
    for programmer in ${meson_programmer_opts}; do
            single_meson_build ${programmer}
    done
    ```

• File test_build.sh:

  • Patch Set #16, Line 15: auto

    Why have `auto` here?

To view, visit change 66475. To unsubscribe, or for help writing mail filters, visit settings.