David Hendricks posted comments on this change.

View Change

Patch set 1:

Yes - I did that in the follow-up patch. This was intended to be as much of a straight import as possible, with conflict resolution where necessary.

The error you mention was fixed in https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/310927 . However since that patch touches a few files we don't have in upstream I had to skip it.

The plan is to squash some of these patches together, particularly the ones which fix small things, so that it's easier for others (particularly Nico) to review.

To view, visit change 22501. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b8963874722ea80299e9298101409408d6c253
Gerrit-Change-Number: 22501
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Shawn Nematbakhsh <shawnn@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 20 Nov 2017 06:00:27 +0000
Gerrit-HasComments: No