Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #17, Line 220:

    		ret = flashrom_wp_set_range(flash, &cfg, &range);
    		if (ret) {
    			msg_gerr("The chip does not support the requested range.\n");
    			return ret;
    		}
    
    		/* Write range before other operations (i.e. enabling HW protection) */
    		ret = write_wp_config(flash, &cfg);
    		if (ret)
    			return ret;
    

    > It's good to know there is no harm, but is there any effect of doing 1,2 without 3? What would be […]

    Ok, thank you for explaining, so error messages is the only inconvenience, is that correct?

    I am wondering about printing messages. Currently it is done by `msg_gerr`, but I don't think it is specific to cli_classic? msg_gerr together with msg_pdbg, msg_ginfo etc are used literally everywhere in codebase, including libflashrom.c. Why they can't be used inside flashrom_wp_set_range or mega_flashrom_wp_set_range?

To view, visit change 58738. To unsubscribe, or for help writing mail filters, visit settings.