View Change

6 comments:

• File sb600spi.c:

  • Patch Set #5, Line 526: * sb7xx, sp5100: PM_Reg: B0h-B1h) etc. */

    Looks like this comment could use an update.

  • Patch Set #5, Line 533: /* On Yangtze and newer chips, check the EcEnableStrap bit */

    I'm not familiar with the AMD chipsets... but comment above seems to suggest,
    that the strap existed before Yangtze, why the constraint?

  • Patch Set #5, Line 534:

    spurious space

  • Patch Set #5, Line 535: ACPI_MMIO_BASE & 0xfffff000

    It's a constant, and this masking is a no-op?

  • Patch Set #5, Line 535: AcpiMMIO

    lower-case, please. e.g. `acpi_mmio`

  • Patch Set #5, Line 548: msg_pinfo

    msg_perr()?

To view, visit change 36424. To unsubscribe, or for help writing mail filters, visit settings.