I like the idea of aligning to tabs, but I think that will require a lot more effort to fix the output. I tested an alternative approach (linked in the comment, along with a longer explanation).
Patch set 1:Code-Review -1
1 comment:
Patch Set #1, Line 404: msg_pinfo
wwhy isn't this `msg_ginfo` like everything else?
Unfortunately this still shows some unaligned entries in `flashrom -L` output. The problem is that the strings that test_state_to_text() outputs are significantly longer than the strings that were output originally, and some are longer than a tabstop. (And tabstop is defined by the user's terminal, so that's another can of worms...)
Another issue is that the preceding strings aren't necessarily aligned on tabs. Instead, they use for-loops to pad the field with spaces up to its maximum length.
With all this in mind, I came up with an alternative approach that seems to fix the issue: https://review.coreboot.org/c/flashrom/+/37407
To view, visit change 37372. To unsubscribe, or for help writing mail filters, visit settings.