Patch Set 1:

(2 comments)

I was able to test this and it works with one small change (see
comments).

I used an SF600 with firmware 7.2.21, with W25Q256JVFM and
MX25L25735FMI and wrote to 1MB ranges in the lower and upper halves
of the chip.

At least something works now...

Did you test the native instructions only? e.g. you could remove
the native flags / erase functions (and in another step the enter
4BA flags) for your chip to test different paths.

I think so... I tried with only FEATURE_4BA_NATIVE enabled and I also tried with only FEATURE_4BA enabled, the former should have used native instructions only, right?

Maybe we should add a chip test mode to flashrom first.

Yes, I think that would be a great idea.

Built-in chip testing has been on my TODO list for a while. I hacked up something for testing write-protection capabilities a while back for CrOS flashrom: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/386428

With all
the possible Dedicrap programmers, hardware and firmware revisions
we'll have a lot to test; or start to whitelist individual combi-
nations :-/

May as well start with what we know works.

View Change

2 comments:

To view, visit change 28804. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841
Gerrit-Change-Number: 28804
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Ronald G. Minnich <rminnich@gmail.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 22:48:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No