Attention is currently required from: Nico Huber.
View Change
1 comment:
File board_enable.c:
Patch Set #3, Line 1097: dev = pcidev_clonedev(dev);
NB. does the code here make sense to anyone? It looks like it's […]
I didn't understand what is actionable here?
I renamed the function as per your previous comment. My suggestion would be to rename back to pcidev_getdev() and call it pcidev_getdev1()
WDYT?
To view, visit change 59276. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id9ce055d5e5d347520ec5002b8c6548e60eaa0a7
Gerrit-Change-Number: 59276
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Wed, 23 Feb 2022 23:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment