Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

Patch set 3:Code-Review +1

View Change

2 comments:

• File buspirate_spi.c:

  • Patch Set #3, Line 58: unsigned char **bp_commbuf

    does this actually need double indirection?

  • Patch Set #3, Line 221: unsigned char *const bp_commbuf = bp_data->bp_commbuf;

    perhaps just move this up a few lines to the functions preamble so that the branch line above can be made shorter by using the itermediate.

To view, visit change 52958. To unsubscribe, or for help writing mail filters, visit settings.