Attention is currently required from: Subrata Banik, Angel Pons.
View Change
1 comment:
File ichspi.c:
Patch Set #6, Line 91: /* New HSFC Control bit */
If you have doubts that the bit was introduced with PCH100, you can always
test the hardware.
Do we have any action item here regarding the open comment or we are good here ?
If you think the code should be changed because the bit existed earlier,
you should confirm that by testing the bit on respective hardware. If it
didn't exist earlier, there is nothing to change, I suppose.
Ref to Intel doc 355845 section 22.1.3. Bit 7:3 are reserved, so, WET bit does exist there.
I can't find that document, what is its title? And I don't understand,
why does it exist when the doc says reserved?
To view, visit change 62888. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id32cb4ccb83dd08e9b0b1ab30cc8e041dd059f5f
Gerrit-Change-Number: 62888
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Subrata Banik <subi.banik@gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 09:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment