Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Peter Marheine.
View Change
2 comments:
Patchset:
File tests/tests.c:
Patch Set #4, Line 96: return __wrap_open(pathname, flags);
I am sorry I only now noticed this, you don't need to redirect to another wrap, just
`return MOCK_HANDLE;`
If a test wants to have the same logic for open and open64, then that test configures what it wants (defines .open and .open64 to be the same function).
To view, visit change 56911. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5a5c617d1ec35d2a3bbe622e5add82a65eb396f0
Gerrit-Change-Number: 56911
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 06:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment