Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine.
1 comment:
Patchset:
> If nobody knows why this is necessary or how to reproduce, I think it's okay to remove. […]
Unfortunately, this hack survived so long it migrated from the CLI to the library. So a CLI flag won't really provide an escape hatch for all users -- unless you also want to also add a libflashrom flag for it??
I'm still somewhat of a lazy opinion here:
1. I doubt that anything will come of either this CL, nor of a CLI flag that provides a bug-report-escape-hatch for it and
2. the whole `--verify` sequence is trivial enough to emulate on one's own [1]. That gets slightly more complex to implement if people are using environments without basic stuff like a decent shell or tools like `cmp`, or if they're using surgical flags (like `--include`). But it's not that hard.
And the good news is we don't have to try #2 if I'm right about #1 😊
But if you still think we need a flag, I can give it a shot.
And either way, do you want me to start such a mailing list thread, or were you suggesting I do this?
[1] e.g., `flashrom --read /tmp/foo.bin`; `flashrom --write /my/new/image.bin --noverify`; `sleep 1`; `flashrom --read /tmp/bar.bin`; `cmp /tmp/foo.bin /tmp/bar.bin`
To view, visit change 80807. To unsubscribe, or for help writing mail filters, visit settings.